[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240819193641.600176-1-harshit.m.mogalapalli@oracle.com>
Date: Mon, 19 Aug 2024 12:36:40 -0700
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Lizhi Hou <lizhi.hou@....com>, Brian Xu <brian.xu@....com>,
Raj Kumar Rampelli <raj.kumar.rampelli@....com>,
Vinod Koul <vkoul@...nel.org>, Michal Simek <michal.simek@....com>,
Sonal Santan <sonal.santan@....com>, Max Zhen <max.zhen@....com>,
dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Cc: dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
error27@...il.com, harshit.m.mogalapalli@...cle.com
Subject: [PATCH] dmaengine: xilinx: xdma: Fix IS_ERR() vs NULL bug in xdma_probe()
devm_regmap_init_mmio() returns error pointers on error, it doesn't
return NULL. Update the error check.
Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
---
This is based on static analysis with smatch, only compile tested.
---
drivers/dma/xilinx/xdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
index 718842fdaf98..44fae351f0a0 100644
--- a/drivers/dma/xilinx/xdma.c
+++ b/drivers/dma/xilinx/xdma.c
@@ -1240,7 +1240,8 @@ static int xdma_probe(struct platform_device *pdev)
xdev->rmap = devm_regmap_init_mmio(&pdev->dev, reg_base,
&xdma_regmap_config);
- if (!xdev->rmap) {
+ if (IS_ERR(xdev->rmap)) {
+ ret = PTR_ERR(xdev->rmap);
xdma_err(xdev, "config regmap failed: %d", ret);
goto failed;
}
--
2.39.3
Powered by blists - more mailing lists