linux-kernel - Re: [PATCH v2 0/9] SEV Kernel Selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMkAt6o1KZH=fTWWOoPf+Z0j12xUYrbqj=Qob4E1LxJBtivo4w@mail.gmail.com>
Date: Mon, 19 Aug 2024 13:43:59 -0600
From: Peter Gonda <pgonda@...gle.com>
To: "Pratik R. Sampat" <pratikrajesh.sampat@....com>
Cc: kvm@...r.kernel.org, seanjc@...gle.com, pbonzini@...hat.com, 
	thomas.lendacky@....com, michael.roth@....com, shuah@...nel.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/9] SEV Kernel Selftests

On Fri, Aug 16, 2024 at 1:23 PM Pratik R. Sampat
<pratikrajesh.sampat@....com> wrote:
>
> This series primarily introduces SEV-SNP test for the kernel selftest
> framework. It tests boot, ioctl, pre fault, and fallocate in various
> combinations to exercise both positive and negative launch flow paths.
>
> Patch 1 - Adds a wrapper for the ioctl calls that decouple ioctl and
> asserts which enables the use of negative test cases. No functional
> change intended.
> Patch 2 - Extend the sev smoke tests to use the SNP specific ioctl
> calls and sets up memory to boot a SNP guest VM
> Patch 3 - Adds SNP to shutdown testing
> Patch 4, 5 - Tests the ioctl path for SEV, SEV-ES and SNP
> Patch 6 - Adds support for SNP in KVM_SEV_INIT2 tests
> Patch 7,8,9 - Enable Prefault tests for SEV, SEV-ES and SNP
>
> The patchset is rebased on top of kvm/queue and and over the
> "KVM: selftests: Add SEV-ES shutdown test" patch.
> https://lore.kernel.org/kvm/20240709182936.146487-1-pgonda@google.com/
>
> v2:
> 1. Add SMT parsing check to populate SNP policy flags
> 2. Extend Peter Gonda's shutdown test to include SNP

Thanks for this.

> 3. Introduce new tests for prefault which include exercising prefault,
>    fallocate, hole-punch in various combinations.
> 4. Decouple ioctl patch reworked to introduce private variants of the
>    the functions that call into the ioctl. Also reordered the patch for
>    it to arrive first so that new APIs are not written right after
>    their introduction.
> 5. General cleanups - adding comments, avoiding local booleans, better
>    error message. Suggestions incorporated from Peter, Tom, and Sean.
>

Tested the entire series

Tested-by: Peter Gonda <pgonda@...gle.com>