linux-kernel - Re: [PATCH 1/3] nfsd: bring in support for delstid draft XDR encoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3DB9A299-B55F-45BB-8B28-65F44F14F6A2@oracle.com>
Date: Mon, 19 Aug 2024 19:50:23 +0000
From: Chuck Lever III <chuck.lever@...cle.com>
To: Jeff Layton <jlayton@...nel.org>
CC: Neil Brown <neilb@...e.de>, Dai Ngo <dai.ngo@...cle.com>,
        Olga
 Kornievskaia <okorniev@...hat.com>, Tom Talpey <tom@...pey.com>,
        Trond
 Myklebust <trondmy@...nel.org>,
        Anna Schumaker <anna@...nel.org>, Tom Haynes
	<loghyr@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>
Subject: Re: [PATCH 1/3] nfsd: bring in support for delstid draft XDR encoding



> On Aug 19, 2024, at 9:26 AM, Jeff Layton <jlayton@...nel.org> wrote:
> 
> I'm playing with the new version now and it seems to be much improved.
> Only two real bugs I've hit at this point:
> 
> 1/ Some of the struct specifications need to be typedefs as well. For
> instance, the delstid draft refers to "nfstime4", but the autogenerated
> struct definition doesn't have the typedef for it. It may be best to
> just add typedefs for all of these sorts of structs.

What's the specific symptom? I've been able to catenate nfs4_1.x
and delstid.x, xdrgen builds the header and source without tossing
any exceptions, and gcc compiles it without complaint.

AFAICT, xdrgen will add "struct" where it's necessary.

I've been squirrelly about using "typedef" too often because
the Linux kernel's coding style is to avoid C typedefs for
shorthand structure names.


> 2/ xdrgen_encode_nfstime4 want a pointer to the nfstime4, but the
> autogenerated code for xdrgen_encode_fattr4_time_deleg_access and
> xdrgen_encode_fattr4_time_deleg_modify try to pass it by value instead.

Here's my generated copy of xdrgen_encode_fattr_time_deleg_access:

/* typedef fattr4_time_deleg_access */
static bool __maybe_unused                                                      xdrgen_encode_fattr4_time_deleg_access(struct xdr_stream *xdr, const fattr4_time_deleg_access value)
{
	/* (basic) */
	return xdrgen_encode_nfstime4(xdr, &value);
};

Looks like it does the right thing...?


--
Chuck Lever