linux-kernel - Re: [PATCH v2 07/12] i2c: riic: Define individual arrays to describe the register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dl7vqbmypa6cxzlfutlpnn6tfuxr3elj7wdzway3eyhho5mdxy@ylw2azxpdbdw>
Date: Mon, 19 Aug 2024 21:56:37 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: "wsa+renesas@...g-engineering.com" <wsa+renesas@...g-engineering.com>, 
	Biju Das <biju.das.jz@...renesas.com>, claudiu beznea <claudiu.beznea@...on.dev>, 
	Chris Brandt <Chris.Brandt@...esas.com>, "robh@...nel.org" <robh@...nel.org>, 
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, 
	"magnus.damm@...il.com" <magnus.damm@...il.com>, "mturquette@...libre.com" <mturquette@...libre.com>, 
	"sboyd@...nel.org" <sboyd@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, 
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>, Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v2 07/12] i2c: riic: Define individual arrays to describe
 the register offsets

Hi Geert,

I've been reading all the review history of this series and now
I'm walking through all the review history again do see if
everything has been 

> > >>>> On the manual I've downloaded from Renesas web site the FMPE bit of RIICnFER is not available on
> > >>>> RZ/A1H.
> > >>>
> > >>> I just found RZ/A2M manual, it supports FMP and register layout looks similar to RZ/G2L.
> > >>
> > >> I introduced struct riic_of_data::fast_mode_plus because of RZ/A1H.
> > >
> > > Do you need to check for that?
> > >
> > > The ICFER_FMPE bit won't be set unless the user specifies the FM+
> > > clock-frequency.  Setting clock-frequency beyond Fast Mode on RZ/A1H
> > > would be very wrong.
> >
> > I need it to avoid this scenario ^. In patch 09/12 there is this code:
> >
> > +       if ((!info->fast_mode_plus && t->bus_freq_hz > I2C_MAX_FAST_MODE_FREQ) ||
> > +           (info->fast_mode_plus && t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ)) {
> > +               dev_err(dev, "unsupported bus speed (%dHz). %d max\n", t->bus_freq_hz,
> > +                       info->fast_mode_plus ? I2C_MAX_FAST_MODE_PLUS_FREQ :
> > +                       I2C_MAX_FAST_MODE_FREQ);
> >                 return -EINVAL;
> >
> > to avoid giving the user the possibility to set FM+ freq on platforms not
> > supporting it.
> >
> > Please let me know if I'm missing something (or wrongly understood your
> > statement).
> 
> Wolfram/Andi: what is your view on this?

I don't have anything against it... what exactly are you
proposing here?

If you want you can directly reply to the v4 6/11 patch.

Thanks Geert for checking on this series.
Andi