linux-kernel - [PATCH -next] spi: bcm63xx: Fix missing pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240819040310.2801422-1-ruanjinjie@huawei.com>
Date: Mon, 19 Aug 2024 12:03:10 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: <jonas.gorski@...il.com>, <broonie@...nel.org>, <noltari@...il.com>,
	<linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <ruanjinjie@...wei.com>
Subject: [PATCH -next] spi: bcm63xx: Fix missing pm_runtime_disable()

The pm_runtime_disable() is missing in the remove function, add it to
align with the probe error path.

Fixes: 2d13f2ff6073 ("spi: bcm63xx-spi: fix pm_runtime")
Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
---
 drivers/spi/spi-bcm63xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 289f8a94980b..0531b6f3eef3 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -614,6 +614,8 @@ static void bcm63xx_spi_remove(struct platform_device *pdev)
 	/* reset spi block */
 	bcm_spi_writeb(bs, 0, SPI_INT_MASK);
 
+	pm_runtime_disable(&pdev->dev);
+
 	/* HW shutdown */
 	clk_disable_unprepare(bs->clk);
 }
-- 
2.34.1