linux-kernel - Re: [BUG] Rockchip SPI: Runtime PM usage count underflow!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <164916293044ff73e8b35e9a9ab4283b@manjaro.org>
Date: Mon, 19 Aug 2024 22:14:10 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Vicente Bergas <vicencb@...il.com>
Cc: Diederik de Haas <didi.debian@...ow.org>, Huang-Huang Bao <i@....me>,
 "Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
 linux-spi@...r.kernel.org, Heiko Stuebner <heiko@...ech.de>, Linus Walleij
 <linus.walleij@...aro.org>, Sasha Levin <sashal@...nel.org>,
 linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, Linux Kernel
 Mailing List <linux-kernel@...r.kernel.org>, Mark Brown <broonie@...nel.org>
Subject: Re: [BUG] Rockchip SPI: Runtime PM usage count underflow!

On 2024-08-19 16:37, Vicente Bergas wrote:
> On Mon, Aug 19, 2024 at 3:33 PM Diederik de Haas 
> <didi.debian@...ow.org> wrote:
>> 
>> On Mon Aug 19, 2024 at 3:14 PM CEST, Vicente Bergas wrote:
>> > On Mon, Aug 19, 2024 at 2:49 PM Vicente Bergas <vicencb@...il.com> wrote:
>> > > On Mon, Aug 19, 2024 at 4:12 AM Vicente Bergas <vicencb@...il.com> wrote:
>> > > > > i am a user of the CONFIG_SPI_SPIDEV device.
>> > > > > It stopped working between 6.8 and 6.10.5.
>> > > > > The SPI bus itself reports no errors to userspace, but no devices
>> > > > > appear connected to the bus.
>> > > > > The platform used is RK3328.
>> > > > > The only spi-related message in dmesg is:
>> > > > > rockchip-spi ff190000.spi: Runtime PM usage count underflow!
>> 
>> FWIW: I've seen this issue as well.
>> 
>> > > Added:
>> > > Huang-Huang Bao <i@....me>
>> > > Linus Walleij <linus.walleij@...aro.org>
>> > > Sasha Levin <sashal@...nel.org>
>> > >
>> > > The first offending commit is:
>> > > 29d8101fb9442544077e68e27839a1979f85633d pinctrl: rockchip: fix pinmux
>> > > bits for RK3328 GPIO2-B pins
>> > >
>> > > I've also tested 6.10.6 with it reverted (and
>> > > 456447ff1fe3c28e2fd7b57a79650f62245c6428 and
>> > > 7127c68c76f120367b9a5053f524df0b603d4a48 as dependencies) and SPI
>> > > works fine.
>> >
>> > Sorry for the noise:
>> > reverting only 29d8101fb9442544077e68e27839a1979f85633d makes it work on 6.10.6.
>> > Ignore what i said about 456447ff1fe3c28e2fd7b57a79650f62245c6428 and
>> > 7127c68c76f120367b9a5053f524df0b603d4a48.
>> 
>> Please try if unreverting that commit and adding the following:
>> https://lore.kernel.org/linux-rockchip/20240709105428.1176375-1-i@eh5.me/
>> 
>> fixes the issue as well.
> 
> I confirm that 6.10.6 without any reverts plus
> 20240709105428.1176375-1-i@....me also fixes the issue.
> Thank you all.

Great!  Could you, please, provide your Tested-by in the patch thread
linked above?  That should help with getting that patch merged upstream.