linux-kernel - Re: [PATCH 2/9] PCI: Make pcim_iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <309d9abd-e60b-4e8b-8def-7c4430635422@kernel.org>
Date: Tue, 20 Aug 2024 08:08:07 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Philipp Stanner <pstanner@...hat.com>, onathan Corbet <corbet@....net>,
 Jens Axboe <axboe@...nel.dk>, Wu Hao <hao.wu@...el.com>,
 Tom Rix <trix@...hat.com>, Moritz Fischer <mdf@...nel.org>,
 Xu Yilun <yilun.xu@...el.com>, Andy Shevchenko <andy@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Alvaro Karsz <alvaro.karsz@...id-run.com>,
 "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez
 <eperezma@...hat.com>, Richard Cochran <richardcochran@...il.com>,
 Mark Brown <broonie@...nel.org>, David Lechner <dlechner@...libre.com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Hannes Reinecke <hare@...e.de>, Chaitanya Kulkarni <kch@...dia.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-block@...r.kernel.org, linux-fpga@...r.kernel.org,
 linux-gpio@...r.kernel.org, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
 virtualization@...ts.linux.dev
Subject: Re: [PATCH 2/9] PCI: Make pcim_iounmap_region() a public function

On 8/20/24 01:51, Philipp Stanner wrote:
> The function pcim_iounmap_regions() is problematic because it uses a
> bitmask mechanism to release / iounmap multiple BARs at once. It, thus,
> prevents getting rid of the problematic iomap table mechanism which was
> deprecated in commit e354bb84a4c1 ("PCI: Deprecate pcim_iomap_table(),
> pcim_iomap_regions_request_all()").
> 
> Make pcim_iounmap_region() public as the successor of
> pcim_iounmap_regions().
> 
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>

Looks fine, but as commented on patch 1, I think this would look better squashed
with patch 1.

Anyway:

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

-- 
Damien Le Moal
Western Digital Research