linux-kernel - Re: ACPI IRQ storm with 6.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <782b7159-076a-4064-8333-69c454972b29@kernel.org>
Date: Mon, 19 Aug 2024 07:23:42 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Len Brown <lenb@...nel.org>,
 "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
 Linux kernel mailing list <linux-kernel@...r.kernel.org>,
 Linux regressions mailing list <regressions@...ts.linux.dev>,
 Tony Nguyen <anthony.l.nguyen@...el.com>, przemyslaw.kitszel@...el.com,
 intel-wired-lan@...ts.osuosl.org, jesse.brandeburg@...el.com,
 "Rafael J. Wysocki" <rafael@...nel.org>, Petr Valenta <petr@...klidu.cz>
Subject: Re: ACPI IRQ storm with 6.10

On 19. 08. 24, 6:50, Jiri Slaby wrote:
> CC e1000e guys + Jesse (due to 75a3f93b5383) + Bjorn (due to b2c289415b2b)

Bjorn,

I am confused by these changes:
==========================================
@@ -291,16 +288,13 @@ static int e1000_set_link_ksettings(struct 
net_device *net
dev,
          * duplex is forced.
          */
         if (cmd->base.eth_tp_mdix_ctrl) {
-               if (hw->phy.media_type != e1000_media_type_copper) {
-                       ret_val = -EOPNOTSUPP;
-                       goto out;
-               }
+               if (hw->phy.media_type != e1000_media_type_copper)
+                       return -EOPNOTSUPP;

                 if ((cmd->base.eth_tp_mdix_ctrl != ETH_TP_MDI_AUTO) &&
                     (cmd->base.autoneg != AUTONEG_ENABLE)) {
                         e_err("forcing MDI/MDI-X state is not supported 
when lin
k speed and/or duplex are forced\n");
-                       ret_val = -EINVAL;
-                       goto out;
+                       return -EINVAL;
                 }
         }

@@ -347,7 +341,6 @@ static int e1000_set_link_ksettings(struct 
net_device *netde
v,
         }

  out:
-       pm_runtime_put_sync(netdev->dev.parent);
         clear_bit(__E1000_RESETTING, &adapter->state);
         return ret_val;
  }
==========================================

So no more clear_bit(__E1000_RESETTING in the above fail paths. Is that 
intentional?

thanks,
-- 
js
suse labs