linux-kernel - RE: [PATCH 3/4] dt-bindings: clock: Add AST2700 clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OS8PR06MB7541A7E690A2D72BA671622EF28C2@OS8PR06MB7541.apcprd06.prod.outlook.com>
Date: Mon, 19 Aug 2024 05:55:54 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Christophe JAILLET
	<christophe.jaillet@...adoo.fr>, Lee Jones <lee@...nel.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, Andrew Jeffery
	<andrew@...econstruct.com.au>, Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>
Subject: RE: [PATCH 3/4] dt-bindings: clock: Add AST2700 clock bindings

> Subject: Re: [PATCH 3/4] dt-bindings: clock: Add AST2700 clock bindings
> 
> On 13/08/2024 03:53, Ryan Chen wrote:
> >> Drop the define for number of clocks from the header, because it is
> >> not a
> 
> *NUMBER OF CLOCKS*
> 
> >> binding. You can put it in the driver or not, I don't care and do not
> >> provide guidance on this because I don't know if it makes sense at all.
> >> What I know is that number of clocks is not related to binding. It is
> >> not needed
> 
> *NUMBER OF CLOCKS*
> 
> >> in the binding, either.
> >
> > Sorry, I am confused.
> > if you think that number of clocks is not related to binding.
> 
> *NUMBER OF CLOCKS*
> 
> > How dtsi claim for clk?
> > For example in dtsi.
> > include <dt-bindings/clock/aspeed,ast2700-clk.h>
> > usb3bhp: usb3bhp {
> > ....
> > clocks = <&syscon0 SCU0_CLK_GATE_PORTAUSB>;
> 
> And where is *NUMBER OF CLOCKS* here? I don't see any problem. No
> useless SCU0_CLK_GATE_NUM define here.
> 
Understood now, I will remove those *NUMBER OF CLOCKS*.
And will replace to 
#define SCU0_CLK_END  34

Refer:
https://github.com/torvalds/linux/blob/master/include/dt-bindings/clock/imx8-clock.h#L87

> > ...
> > }
> >
> > It need for dtsi binding include for clock enable.
> >
> > If there is no binding clock include file, how device know the clock index?
> 
> Just look how ALL other bindings for new platforms are doing it. Why are we
> discussing obvious kernel aspects? Spend time to read other drivers before
> posting yours.
> 
> Best regards,
> Krzysztof