linux-kernel - [PATCH] clocksource/timer-of: Add missing casts to percpu address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240819061351.14782-1-ubizjak@gmail.com>
Date: Mon, 19 Aug 2024 08:13:45 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: linux-kernel@...r.kernel.org
Cc: Uros Bizjak <ubizjak@...il.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: [PATCH] clocksource/timer-of: Add missing casts to percpu address space

Add missing casts to percpu address space to fix

timer-of.c:29:46: warning: incorrect type in argument 2 (different address spaces)
timer-of.c:29:46:    expected void [noderef] __percpu *
timer-of.c:29:46:    got struct clock_event_device *clkevt
timer-of.c:74:51: warning: incorrect type in argument 4 (different address spaces)
timer-of.c:74:51:    expected void [noderef] __percpu *percpu_dev_id
timer-of.c:74:51:    got struct clock_event_device *clkevt

sparse warnings.

Found by GCC's named address space checks.

There were no changes in the resulting object file.

Signed-off-by: Uros Bizjak <ubizjak@...il.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
---
 drivers/clocksource/timer-of.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c
index c3f54d9912be..7e0375a804ff 100644
--- a/drivers/clocksource/timer-of.c
+++ b/drivers/clocksource/timer-of.c
@@ -26,7 +26,8 @@ static __init void timer_of_irq_exit(struct of_timer_irq *of_irq)
 	struct clock_event_device *clkevt = &to->clkevt;
 
 	if (of_irq->percpu)
-		free_percpu_irq(of_irq->irq, clkevt);
+		free_percpu_irq(of_irq->irq,
+				(void __percpu *)(unsigned long)clkevt);
 	else
 		free_irq(of_irq->irq, clkevt);
 }
@@ -70,8 +71,8 @@ static __init int timer_of_irq_init(struct device_node *np,
 	}
 
 	ret = of_irq->percpu ?
-		request_percpu_irq(of_irq->irq, of_irq->handler,
-				   np->full_name, clkevt) :
+		request_percpu_irq(of_irq->irq, of_irq->handler, np->full_name,
+				   (void __percpu *)(unsigned long)clkevt) :
 		request_irq(of_irq->irq, of_irq->handler,
 			    of_irq->flags ? of_irq->flags : IRQF_TIMER,
 			    np->full_name, clkevt);
-- 
2.46.0