linux-kernel - Re: [PATCH 1/3] nfsd: bring in support for delstid draft XDR encoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <172402584064.6062.2891331764461009092@noble.neil.brown.name>
Date: Mon, 19 Aug 2024 10:04:00 +1000
From: "NeilBrown" <neilb@...e.de>
To: "Jeff Layton" <jlayton@...nel.org>
Cc: "Chuck Lever" <chuck.lever@...cle.com>,
 "Olga Kornievskaia" <kolga@...app.com>, "Dai Ngo" <Dai.Ngo@...cle.com>,
 "Tom Talpey" <tom@...pey.com>, "Trond Myklebust" <trondmy@...nel.org>,
 "Anna Schumaker" <anna@...nel.org>, "Tom Haynes" <loghyr@...il.com>,
 linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
 "Jeff Layton" <jlayton@...nel.org>
Subject: Re: [PATCH 1/3] nfsd: bring in support for delstid draft XDR encoding

On Fri, 16 Aug 2024, Jeff Layton wrote:

> +// Generated by lkxdrgen, with hand-edits.

I *really* don't like having code in the kernel that is partly
tool-generated and partly human-generated, and where the boundary isn't
obvious (like separate files).

If we cannot use tool-generated code as-is, then let's fix the tool.
If we cannot fix the tool, then include the raw output and a
human-generated patch which the makefile combines.

Ideally the tool should be in tools/, the .x file should be in fs/nfsd/
and the makefile should apply the one to the other.  We are going to
want to do that eventually and I think it should be priority.  The tool
doesn't have to be bug-free before it lands (nothing is).

A particular reason for this is that I cannot review tool-generated
hand-editted code.  It is too noisy and I don't know which parts are
worth closer inspection etc.

Thanks,
NeilBrown