linux-kernel - Re: [PATCH -next] ceph: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74549d76-1187-4ed6-9589-e5978ba513d0@redhat.com>
Date: Mon, 19 Aug 2024 09:16:51 +0800
From: Xiubo Li <xiubli@...hat.com>
To: Yue Haibing <yuehaibing@...wei.com>, idryomov@...il.com,
 mchangir@...hat.com, jlayton@...nel.org
Cc: ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ceph: Remove unused declarations


On 8/14/24 11:34, Yue Haibing wrote:
> These functions is never implemented and used.
>
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>   fs/ceph/mds_client.h            | 3 ---
>   fs/ceph/super.h                 | 2 --
>   include/linux/ceph/osd_client.h | 2 --
>   3 files changed, 7 deletions(-)
>
> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
> index 9bcc7f181bfe..585ab5a6d87d 100644
> --- a/fs/ceph/mds_client.h
> +++ b/fs/ceph/mds_client.h
> @@ -559,9 +559,6 @@ extern struct ceph_mds_session *
>   ceph_get_mds_session(struct ceph_mds_session *s);
>   extern void ceph_put_mds_session(struct ceph_mds_session *s);
>   
> -extern int ceph_send_msg_mds(struct ceph_mds_client *mdsc,
> -			     struct ceph_msg *msg, int mds);
> -
>   extern int ceph_mdsc_init(struct ceph_fs_client *fsc);
>   extern void ceph_mdsc_close_sessions(struct ceph_mds_client *mdsc);
>   extern void ceph_mdsc_force_umount(struct ceph_mds_client *mdsc);
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index 6e817bf1337c..c88bf53f68e9 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -1056,8 +1056,6 @@ extern int ceph_fill_trace(struct super_block *sb,
>   extern int ceph_readdir_prepopulate(struct ceph_mds_request *req,
>   				    struct ceph_mds_session *session);
>   
> -extern int ceph_inode_holds_cap(struct inode *inode, int mask);
> -
>   extern bool ceph_inode_set_size(struct inode *inode, loff_t size);
>   extern void __ceph_do_pending_vmtruncate(struct inode *inode);
>   
> diff --git a/include/linux/ceph/osd_client.h b/include/linux/ceph/osd_client.h
> index f66f6aac74f6..d7941478158c 100644
> --- a/include/linux/ceph/osd_client.h
> +++ b/include/linux/ceph/osd_client.h
> @@ -449,8 +449,6 @@ extern int ceph_osdc_init(struct ceph_osd_client *osdc,
>   extern void ceph_osdc_stop(struct ceph_osd_client *osdc);
>   extern void ceph_osdc_reopen_osds(struct ceph_osd_client *osdc);
>   
> -extern void ceph_osdc_handle_reply(struct ceph_osd_client *osdc,
> -				   struct ceph_msg *msg);
>   extern void ceph_osdc_handle_map(struct ceph_osd_client *osdc,
>   				 struct ceph_msg *msg);
>   void ceph_osdc_update_epoch_barrier(struct ceph_osd_client *osdc, u32 eb);

Reviewed-by: Xiubo Li <xiubli@...hat.com>

Thanks!