linux-kernel - RE: [PATCH] clk: starfive: Use pm_runtime_resume_and_get to fix pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <NTZPR01MB09564D3E3AE489D9C8101B8F9F8C2@NTZPR01MB0956.CHNPR01.prod.partner.outlook.cn>
Date: Mon, 19 Aug 2024 08:30:18 +0000
From: Xingyu Wu <xingyu.wu@...rfivetech.com>
To: Yuntao Liu <liuyuntao12@...wei.com>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "kernel@...il.dk" <kernel@...il.dk>, Hal Feng <hal.feng@...rfivetech.com>,
	"mturquette@...libre.com" <mturquette@...libre.com>, "sboyd@...nel.org"
	<sboyd@...nel.org>, "conor.dooley@...rochip.com"
	<conor.dooley@...rochip.com>, "palmer@...osinc.com" <palmer@...osinc.com>
Subject: RE: [PATCH] clk: starfive: Use pm_runtime_resume_and_get to fix
 pm_runtime_get_sync() usage

On 15/08/2024 20:19, Yuntao Liu wrote:
> 
> We need to call pm_runtime_put_noidle() when pm_runtime_get_sync() fails,
> so use pm_runtime_resume_and_get() instead. this function will handle this.
> 
> Fixes: dae5448a327ed ("clk: starfive: Add StarFive JH7110 Video-Output clock
> driver")
> Signed-off-by: Yuntao Liu <liuyuntao12@...wei.com>
> ---
>  drivers/clk/starfive/clk-starfive-jh7110-vout.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/starfive/clk-starfive-jh7110-vout.c
> b/drivers/clk/starfive/clk-starfive-jh7110-vout.c
> index 53f7af234cc2..aabd0484ac23 100644
> --- a/drivers/clk/starfive/clk-starfive-jh7110-vout.c
> +++ b/drivers/clk/starfive/clk-starfive-jh7110-vout.c
> @@ -145,7 +145,7 @@ static int jh7110_voutcrg_probe(struct platform_device
> *pdev)
> 
>  	/* enable power domain and clocks */
>  	pm_runtime_enable(priv->dev);
> -	ret = pm_runtime_get_sync(priv->dev);
> +	ret = pm_runtime_resume_and_get(priv->dev);
>  	if (ret < 0)
>  		return dev_err_probe(priv->dev, ret, "failed to turn on
> power\n");
> 

It looks good. Thanks for your patch.

Reviewed-by: Xingyu Wu <xingyu.wu@...rfivetech.com>

Best regards,
Xingyu Wu