linux-kernel - Re: [PATCH -next 4/9] i2c: at91: fix module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6a11b136-025c-4790-a7d6-4a76a5ede336@app.fastmail.com>
Date: Mon, 19 Aug 2024 13:55:50 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Yuntao Liu" <liuyuntao12@...wei.com>,
 openipmi-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
 "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
 linux-i2c@...r.kernel.org, linux-usb@...r.kernel.org
Cc: "Corey Minyard" <minyard@....org>,
 "Ludovic.Desroches" <ludovic.desroches@...rochip.com>,
 "Vinod Koul" <vkoul@...nel.org>, "Daniel Mack" <daniel@...que.org>,
 "Haojian Zhuang" <haojian.zhuang@...il.com>,
 "Robert Jarzmik" <robert.jarzmik@...e.fr>, morbidrsa@...il.com,
 "Borislav Petkov" <bp@...en8.de>, "Tony Luck" <tony.luck@...el.com>,
 "James Morse" <james.morse@....com>,
 "Mauro Carvalho Chehab" <mchehab@...nel.org>,
 "Robert Richter" <rric@...nel.org>, codrin.ciubotariu@...rochip.com,
 "Andi Shyti" <andi.shyti@...nel.org>,
 "Nicolas Ferre" <nicolas.ferre@...rochip.com>,
 "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
 "Claudiu Beznea" <claudiu.beznea@...on.dev>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Alan Stern" <stern@...land.harvard.edu>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Duje Mihanović <duje.mihanovic@...le.hr>,
 "Mark Brown" <broonie@...nel.org>,
 "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH -next 4/9] i2c: at91: fix module autoloading

On Mon, Aug 19, 2024, at 13:38, Yuntao Liu wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from platform_device_id table.
>
> Signed-off-by: Yuntao Liu <liuyuntao12@...wei.com>
> ---
>  drivers/i2c/busses/i2c-at91-core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-at91-core.c 
> b/drivers/i2c/busses/i2c-at91-core.c
> index dc52b3530725..bc3636f90712 100644
> --- a/drivers/i2c/busses/i2c-at91-core.c
> +++ b/drivers/i2c/busses/i2c-at91-core.c
> @@ -107,6 +107,7 @@ static const struct platform_device_id 
> at91_twi_devtypes[] = {
>  		/* sentinel */
>  	}
>  };
> +MODULE_DEVICE_TABLE(platform, at91_twi_devtypes);
> 
>  #if defined(CONFIG_OF)
>  static struct at91_twi_pdata at91sam9x5_config = {
> -- 

This device is always probed from DT, so a better fix would
be to remove the table and the #ifdef/of_match_ptr() around
the atmel_twi_dt_ids.

     Arnd