linux-kernel - Re: [PATCH] clocksource/drivers/timer-of: Remove percpu irq related code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df4d5786-6345-42d2-b3bd-a0cd03d83495@linaro.org>
Date: Mon, 19 Aug 2024 13:59:54 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-of: Remove percpu irq related
 code

On 19/08/2024 13:12, Uros Bizjak wrote:
> On Mon, Aug 19, 2024 at 12:03 PM Daniel Lezcano
> <daniel.lezcano@...aro.org> wrote:
>>
>> Found by GCC's named address space checks:
>>
>> timer-of.c:29:46: warning: incorrect type in argument 2 (different address spaces)
>> timer-of.c:29:46:    expected void [noderef] __percpu *
>> timer-of.c:29:46:    got struct clock_event_device *clkevt
>> timer-of.c:74:51: warning: incorrect type in argument 4 (different address spaces)
>> timer-of.c:74:51:    expected void [noderef] __percpu *percpu_dev_id
>> timer-of.c:74:51:    got struct clock_event_device *clkevt
> 
> Actually, the above is what sparse reports. GCC's named address space
> checks errors out with:
> 
> drivers/clocksource/timer-of.c: In function ‘timer_of_irq_exit’:
> drivers/clocksource/timer-of.c:29:46: error: passing argument 2 of
> ‘free_percpu_irq’ from pointer to non-enclosed address space
>    29 |                 free_percpu_irq(of_irq->irq, clkevt);
>       |                                              ^~~~~~
> In file included from drivers/clocksource/timer-of.c:8:
> ./include/linux/interrupt.h:201:43: note: expected ‘__seg_gs void *’
> but argument is of type ‘struct clock_event_device *’
>   201 | extern void free_percpu_irq(unsigned int, void __percpu *);
>       |                                           ^~~~~~~~~~~~~~~
> drivers/clocksource/timer-of.c: In function ‘timer_of_irq_init’:
> drivers/clocksource/timer-of.c:74:51: error: passing argument 4 of
> ‘request_percpu_irq’ from pointer to non-enclosed address space
>    74 |                                    np->full_name, clkevt) :
>       |                                                   ^~~~~~
> ./include/linux/interrupt.h:190:56: note: expected ‘__seg_gs void *’
> but argument is of type ‘struct clock_event_device *’
>   190 |                    const char *devname, void __percpu *percpu_dev_id)
>       |                                         ~~~~~~~~~~~~~~~^~~~~~~~~~~~~
> 
> Anyway, your patch fixes the above build errors, as well as sparse
> checking warnings.

Thanks I'll amend the description with your comment

> Tested-by: Uros Bizjak <ubizjak@...il.com>

Thanks for testing

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog