linux-kernel - Re: [PATCH -next 3/8] iommufd/selftest: Make dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53869e06-879f-4a77-ae4d-c91a23b8d6d3@intel.com>
Date: Mon, 19 Aug 2024 20:29:16 +0800
From: Yi Liu <yi.l.liu@...el.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>, <jgg@...pe.ca>,
	<kevin.tian@...el.com>, <joro@...tes.org>, <will@...nel.org>,
	<robin.murphy@....com>, <iommu@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next 3/8] iommufd/selftest: Make dirty_ops static

On 2024/8/19 20:00, Jinjie Ruan wrote:
> The sparse tool complains as follows:
> 
> drivers/iommu/iommufd/selftest.c:277:30: warning:
> 	symbol 'dirty_ops' was not declared. Should it be static?
> 
> This symbol is not used outside of selftest.c, so marks it static.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>   drivers/iommu/iommufd/selftest.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Yi Liu <yi.l.liu@...el.com>

> diff --git a/drivers/iommu/iommufd/selftest.c b/drivers/iommu/iommufd/selftest.c
> index 04293b20e20c..7464c24764cd 100644
> --- a/drivers/iommu/iommufd/selftest.c
> +++ b/drivers/iommu/iommufd/selftest.c
> @@ -274,7 +274,7 @@ static int mock_domain_read_and_clear_dirty(struct iommu_domain *domain,
>   	return 0;
>   }
>   
> -const struct iommu_dirty_ops dirty_ops = {
> +static const struct iommu_dirty_ops dirty_ops = {
>   	.set_dirty_tracking = mock_domain_set_dirty_tracking,
>   	.read_and_clear_dirty = mock_domain_read_and_clear_dirty,
>   };

-- 
Regards,
Yi Liu