linux-kernel - Re: [PATCH] drivers/perf: Fix ali_drw_pmu driver interrupt status clearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <601bf843-94c7-49f7-8fa3-536a118b4ae0@linux.alibaba.com>
Date: Mon, 19 Aug 2024 20:25:29 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Jing Zhang <renyu.zj@...ux.alibaba.com>, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Mark Rutland <mark.rutland@....com>,
 Will Deacon <will@...nel.org>
Subject: Re: [PATCH] drivers/perf: Fix ali_drw_pmu driver interrupt status
 clearing



在 2024/8/19 19:48, Jing Zhang 写道:
> The alibaba_uncore_pmu driver forgot to clear all interrupt status
> in the interrupt processing function. After the PMU counter overflow
> interrupt occurred, an interrupt storm occurred, causing the system
> to hang.
> 
> Therefore, clear the correct interrupt status in the interrupt handling
> function to fix it.
> 
> Signed-off-by: Jing Zhang <renyu.zj@...ux.alibaba.com>
> ---
>   drivers/perf/alibaba_uncore_drw_pmu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
> index 38a2947..c6ff1bc 100644
> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
> @@ -400,7 +400,7 @@ static irqreturn_t ali_drw_pmu_isr(int irq_num, void *data)
>   			}
>   
>   			/* clear common counter intr status */
> -			clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, 1);
> +			clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, status);
>   			writel(clr_status,
>   			       drw_pmu->cfg_base + ALI_DRW_PMU_OV_INTR_CLR);
>   		}

Yes, it is a bug due to typo.

Thank you.

Reviewed-by: Shuai Xue <xueshuai@...ux.alibaba.com>

Shuai