linux-kernel - Re: [PATCH] dt-bindings: mfd: sprd,sc2731: convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKZEAOgEacGmfoJeuNpTpy9oXnG1ghJhAZP8Gkp700ynQ@mail.gmail.com>
Date: Mon, 19 Aug 2024 07:38:29 -0600
From: Rob Herring <robh@...nel.org>
To: Stanislav Jakubek <stano.jakubek@...il.com>
Cc: Lee Jones <lee@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Orson Zhai <orsonzhai@...il.com>, 
	Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: sprd,sc2731: convert to YAML

On Thu, Aug 15, 2024 at 8:38 AM Stanislav Jakubek
<stano.jakubek@...il.com> wrote:
>
> Hi Rob,
>
> [skip]
>
> > > ---
> > > Depends on:
> > >   - eFuse YAML conversion: https://lore.kernel.org/lkml/9fba73ce66f1f3b7b2a8f46e7c21f60cff5a85f0.1721199034.git.stano.jakubek@gmail.com/
> > >   - RTC YAML conversion: https://lore.kernel.org/lkml/ZrBzmQI0IAL7LI3e@standask-GA-A55M-S2HP/
> >
> > These either have to be sent as 1 series for 1 maintainer to apply (Lee)
> > or you'll have to wait a cycle for the dependencies.
>
> I've had this patch sitting on my harddrive for over a month now.
> Both of the dependencies have been sitting on the mailing lists
> pretty much unchanged for about a month as well...
> Also, there are technically more dependencies, but they're in linux-next
> already, so I didn't include them here.

>From who's tree? That affects who can apply this as well. I guess
those are other child nodes.

> Just wanted to get this out to get some feedback (and hope that it would
> move the dependencies along).

And now you have.

>
> [skip]
>
> > The preference is one complete example here and drop any partial
> > examples of the child nodes in the child node schemas.
>
> I can add a more complete example here, sure.
> But I don't understand the point of removing the examples in child node
> bindings. Seems to me like all that would do is provide less documentation.

It's not less, it's just 1 copy instead of 2 (or more). The problem
typically (in the old bindings) is that the parent node is shown, but
is incomplete which is a problem once the schemas check the examples.
And if some of the child nodes are required by the schema, then every
child schema ends up with a complete example of the MFD. And then when
we have to fix something later, there's more places to go fix it.

Rob