linux-kernel - Re: [PATCH] arm-cci: Fix refcount leak in cci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e166d5f-a8cf-46ab-a95d-46bacec58f5f@arm.com>
Date: Mon, 19 Aug 2024 15:28:56 +0100
From: Suzuki K Poulose <suzuki.poulose@....com>
To: Ma Ke <make24@...as.ac.cn>, nico@...xnic.net, will@...nel.org,
 punitagrawal@...il.com, akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] arm-cci: Fix refcount leak in cci_probe

On 19/08/2024 10:04, Ma Ke wrote:
> Add the missing of_node_put() to release the refcount incremented
> by of_find_matching_node().
> 
> Cc: stable@...r.kernel.org
> Fixes: f6b9e83ce05e ("arm-cci: Rearrange code for splitting PMU vs driver code")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
> ---
>   drivers/bus/arm-cci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index b8184a903583..6be7b05b5ff1 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -548,6 +548,7 @@ static int cci_probe(void)
>   	}
>   	if (ret || !cci_ctrl_base) {
>   		WARN(1, "unable to ioremap CCI ctrl\n");
> +		of_node_put(np);
>   		return -ENXIO;
>   	}
>   

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>