linux-kernel - Re: [PATCH 1/7] cgroup: Implement cgroup_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qsdgtsunxgbxb6lf7x7m5777jxmumddomsofuuimqenoyliabx@assdbc6zj2ag>
Date: Tue, 20 Aug 2024 16:38:40 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Tejun Heo <tj@...nel.org>
Cc: void@...ifault.com, peterz@...radead.org, mingo@...hat.com, 
	cgroups@...r.kernel.org, lizefan.x@...edance.com, hannes@...xchg.org, 
	kernel-team@...a.com, linux-kernel@...r.kernel.org, David Vernet <dvernet@...a.com>, 
	Josh Don <joshdon@...gle.com>, Hao Luo <haoluo@...gle.com>, Barret Rhoden <brho@...gle.com>
Subject: Re: [PATCH 1/7] cgroup: Implement cgroup_show_cftypes()

On Wed, Aug 07, 2024 at 02:25:23PM GMT, Tejun Heo <tj@...nel.org> wrote:
> +void cgroup_show_cftype(struct cftype *cft, bool show)
> +{
> +	struct cgroup_subsys *ss = cft->ss;
> +	struct cgroup *root = ss ? &ss->root->cgrp : &cgrp_dfl_root.cgrp;

Strictly speaking, this (v1) cgroup_root dereference should be guarded
with cgroup_mutex too (should be the root destroy concurrently).

> +	struct cgroup_subsys_state *css;
> +
> +	mutex_lock(&cgroup_mutex);

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)