linux-kernel - Re: [PATCH v2] ACPI: APD: Add AMDI0015 as platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0fa061f4-c82b-451b-a12d-e873d853e436@amd.com>
Date: Tue, 20 Aug 2024 21:10:42 +0530
From: Shyam Sundar S K <Shyam-sundar.S-k@....com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: lenb@...nel.org, linux-acpi@...r.kernel.org,
 linux-kernel@...r.kernel.org, Sanket Goswami <Sanket.Goswami@....com>
Subject: Re: [PATCH v2] ACPI: APD: Add AMDI0015 as platform device



On 8/20/2024 20:19, Rafael J. Wysocki wrote:
> On Mon, Aug 12, 2024 at 7:24 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
>>
>> On Mon, Aug 12, 2024 at 08:10:18PM +0530, Shyam Sundar S K wrote:
>>> Add AMDI0015 to the ACPI APD support list to ensure correct clock settings
>>> for the I3C device on the latest AMD platforms.
>>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> from the ACPI ID perspective.
> 
> I've replaced the v1 that has been applied for some time already with
> this one, but please note that it still is not entirely clean.
> 
> Namely, if there are two S-o-b targs on a patch, 2 cases are possible:
> 
> (1) The person sending it is not its author and merely sends someone
> else's work adding an S-o-b to document a "supply chain link".  In
> this case, the From: header should point to the original author (it
> can be added right before the changelog) and its value should match
> the other S-o-b tag exactly.
> 
> (2) The person sending it is one of its authors.  In this case, a
> Co-developed-by tag should be added to point to the other author and
> its value should match the other S-o-b tag exactly.
> 
> I've assumed (2) and added "Co-developed-by: Sanket Goswami
> <Sanket.Goswami@....com>" to the commit, but that's not something I
> should be doing.

Thanks! That was a miss.

Co-developed-by: Sanket Goswami <Sanket.Goswami@....com> is the right tag.

Thanks,
Shyam

> 
> Thanks!