linux-kernel - Re: [PATCH net-next] nfc: st95hf: switch to using sleeping variants of gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsTGgMWvD8b6_8SN@google.com>
Date: Tue, 20 Aug 2024 09:38:24 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Przemek Kitszel <przemyslaw.kitszel@...el.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH net-next] nfc: st95hf: switch to using sleeping variants
 of gpiod API

On Tue, Aug 20, 2024 at 03:53:21PM +0200, Andrew Lunn wrote:
> On Tue, Aug 20, 2024 at 10:10:37AM +0200, Przemek Kitszel wrote:
> > On 8/20/24 03:10, Dmitry Torokhov wrote:
> > > The driver does not not use gpiod API calls in an atomic context. Switch
> > 
> > please remove one "not"
> > 
> > > to gpiod_set_value_cansleep() calls to allow using the driver with GPIO
> > > controllers that might need process context to operate.
> > > 
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > 
> > Code is fine, but why not as a fix?
> 
> Why would this be a fix? What is broken?

No, this is not a fix but a tiny enhancement. As far as I know no
existing devices actually require it.

Thanks.

-- 
Dmitry