[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <426c06ae-90f7-4a58-84e1-aa9389578c60@lunn.ch>
Date: Tue, 20 Aug 2024 18:44:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jonathan Corbet <corbet@....net>, kernel@...gutronix.de,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v2 2/3] ethtool: Add support for specifying
information source in cable test results
On Tue, Aug 20, 2024 at 12:12:55PM +0200, Oleksij Rempel wrote:
> Enhance the ethtool cable test interface by introducing the ability to
> specify the source of the diagnostic information for cable test results.
> This is particularly useful for PHYs that offer multiple diagnostic
> methods, such as Time Domain Reflectometry (TDR) and Active Link Cable
> Diagnostic (ALCD).
>
> Key changes:
> - Added `ethnl_cable_test_result_with_src` and
> `ethnl_cable_test_fault_length_with_src` functions to allow specifying
> the information source when reporting cable test results.
> - Updated existing `ethnl_cable_test_result` and
> `ethnl_cable_test_fault_length` functions to use TDR as the default
> source, ensuring backward compatibility.
> - Modified the UAPI to support these new attributes, enabling drivers to
> provide more detailed diagnostic information.
>
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Andrew
Powered by blists - more mailing lists