linux-kernel - Re: [PATCH] use might_sleep check if kmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsQMgpZpx4oo_a9b@casper.infradead.org>
Date: Tue, 20 Aug 2024 04:24:50 +0100
From: Matthew Wilcox <willy@...radead.org>
To: zhangchun <zhang.chuna@....com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, jiaoxupo@....com, shaohaojize@....com
Subject: Re: [PATCH] use might_sleep check if kmap_high is called from atomic
 context

On Tue, Aug 20, 2024 at 09:53:11AM +0800, zhangchun wrote:
> kmap_high is defined as EXPORT_SYMBOL, and cannot be called from atomic
> context. Add might_sleep check is necessary.

No.  Nobody should be calling kmap_high() directly.  There's already a
might_sleep() in kmap().  No need to add one in kmap_high().