linux-kernel - Re: [PATCH v6 11/22] x86/resctrl: Remove MSR reading of event configuration value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b5aa79e-ab15-4d8d-a00f-3afb8ee21ad6@intel.com>
Date: Tue, 20 Aug 2024 11:09:20 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: <babu.moger@....com>, <corbet@....net>, <fenghua.yu@...el.com>,
	<tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
	<dave.hansen@...ux.intel.com>
CC: <x86@...nel.org>, <hpa@...or.com>, <paulmck@...nel.org>,
	<rdunlap@...radead.org>, <tj@...nel.org>, <peterz@...radead.org>,
	<yanjiewtw@...il.com>, <kim.phillips@....com>, <lukas.bulwahn@...il.com>,
	<seanjc@...gle.com>, <jmattson@...gle.com>, <leitao@...ian.org>,
	<jpoimboe@...nel.org>, <rick.p.edgecombe@...el.com>,
	<kirill.shutemov@...ux.intel.com>, <jithu.joseph@...el.com>,
	<kai.huang@...el.com>, <kan.liang@...ux.intel.com>,
	<daniel.sneddon@...ux.intel.com>, <pbonzini@...hat.com>,
	<sandipan.das@....com>, <ilpo.jarvinen@...ux.intel.com>,
	<peternewman@...gle.com>, <maciej.wieczor-retman@...el.com>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<eranian@...gle.com>, <james.morse@....com>
Subject: Re: [PATCH v6 11/22] x86/resctrl: Remove MSR reading of event
 configuration value

Hi Babu,

On 8/20/24 9:19 AM, Moger, Babu wrote:
> On 8/16/24 16:36, Reinette Chatre wrote:
>> On 8/6/24 3:00 PM, Babu Moger wrote:

>>> Introduce resctrl_arch_event_config_get() and
>>> resctrl_arch_event_config_set() to get/set architecture domain specific
>>> mbm_total_cfg/mbm_local_cfg values. Also, remove unused config value
>>> definitions.
>>
>> hmmm ... while the config values are not used they are now established
>> ABI and any other architecture that wants to support configurable events
>> will need to follow these definitions. It is thus required to keep them
>> documented in the kernel in support of future changes. I
>> understand that they are documented in user docs, but could we keep them
>> in the kernel code also? Since they are unused they could perhaps be moved
>> to comments as a compromise?
> 
> How about just keeping them as is? I will just not remove it.
> 

I am not aware of any policy here. I'm ok with keeping them as is. I do not
know if there are any static checkers that may complain, if there are then
the defines can be moved to comments.

Reinette