linux-kernel - Re: [PATCH v4 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd8b6c1e-f7d7-4db2-b178-7391e3111237@denx.de>
Date: Tue, 20 Aug 2024 05:30:04 +0200
From: Marek Vasut <marex@...x.de>
To: Frank Li <Frank.Li@....com>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Mark Hasemeyer <markhas@...omium.org>,
 Alexander Stein <alexander.stein@...tq-group.com>,
 "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..."
 <linux-input@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH v4 1/1] dt-bindings: input: touchscreen: convert
 ads7846.txt to yaml

On 8/19/24 8:05 PM, Frank Li wrote:

[...]

> +  ti,keep-vref-on:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      set to keep Vref on for differential measurements as well.

Please start sentence with uppercase letter.

> +  ti,pendown-gpio-debounce:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Platform specific debounce time for the pendown-gpio.
> +
> +  ti,penirq-recheck-delay-usecs:
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      If set to non-zero, after samples are taken this delay is applied and
> +      penirq is rechecked, to help avoid false events.  This value is
> +      affected by the material used to build the touch layer.
> +
> +  ti,pressure-max:
> +    deprecated: true
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      Maximum reported pressure value.
> +
> +  ti,pressure-min:
> +    deprecated: true
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      Minimum reported pressure value (threshold).
> +
> +  ti,settle-delay-usec:
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      Settling time of the analog signals; a function of Vcc and the
> +      capacitance on the X/Y drivers.  If set to non-zero, two samples are
> +      taken with settle_delay us apart, and the second one is used. ~150
> +      uSec with 0.01uF caps.
> +
> +  ti,swap-xy:
> +    deprecated: true
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      swap x and y axis.

DTTO

With those two fixed:

Reviewed-by: Marek Vasut <marex@...x.de>

Thanks !