linux-kernel - Re: commit 9d8c094ddab0 breaks Xorg/xfce4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <388a818e-487f-4ec0-8da3-1d51291d2089@amd.com>
Date: Tue, 20 Aug 2024 13:28:59 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Bert Karwatzki <spasswolf@....de>
Cc: linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
 amd-gfx@...ts.freedesktop.org
Subject: Re: commit 9d8c094ddab0 breaks Xorg/xfce4

On 8/1/2024 11:52, Bert Karwatzki wrote:
> Since linux-next-20240801 starting Xorg/xfce4 fails on my MSI Alpha15 Laptop.
> I bisected this to the following commit and reverting this in linux-next-20240801
> fixes the issue for me. Gnome (with Xwayland) works as usual.
> 
> 9d8c094ddab05db88d183ba82e23be807848cad8 is the first bad commit
> commit 9d8c094ddab05db88d183ba82e23be807848cad8
> Author: Mario Limonciello <mario.limonciello@....com>
> Date:   Wed Jul 3 00:17:22 2024 -0500
> 
>      drm/amd: Add power_saving_policy drm property to eDP connectors
> 
>      When the `power_saving_policy` property is set to bit mask
>      "Require color accuracy" ABM should be disabled immediately and
>      any requests by sysfs to update will return an -EBUSY error.
> 
>      When the `power_saving_policy` property is set to bit mask
>      "Require low latency" PSR should be disabled.
> 
>      When the property is restored to an empty bit mask ABM and PSR
>      can be enabled again.
> 
>      Signed-off-by: Mario Limonciello <mario.limonciello@....com>
>      Reviewed-by: Leo Li <sunpeng.li@....com>
>      Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>
>      Link: https://patchwork.freedesktop.org/patch/msgid/20240703051722.328-3-mario.limonciello@amd.com
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c       |  4 ++++
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++-----
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  2 ++
>   3 files changed, 53 insertions(+), 5 deletions(-)
> 
> Bert Karwatzki

Thanks for reporting this.  It's an odd issue!
I could reproduce it using SDDM (which uses X by "default").

Just to close the loop on it, it's been reverted for other reasons:
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/717b432b6d55e1dcefcb5e2ec315bf66b6ab8c54

When something comes back in a different form I'll double check X again too.