linux-kernel - RE: [PATCH net-next v4 1/2] net: xilinx: axienet: Report RxRject as rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB5953E143D4B9D889E428998FB78D2@MN0PR12MB5953.namprd12.prod.outlook.com>
Date: Tue, 20 Aug 2024 18:33:40 +0000
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To: Sean Anderson <sean.anderson@...ux.dev>, Andrew Lunn <andrew@...n.ch>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "Simek, Michal" <michal.simek@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Russell King <linux@...linux.org.uk>, "David
 S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, Simon Horman
	<horms@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH net-next v4 1/2] net: xilinx: axienet: Report RxRject as
 rx_dropped

> -----Original Message-----
> From: Sean Anderson <sean.anderson@...ux.dev>
> Sent: Tuesday, August 20, 2024 11:24 PM
> To: Andrew Lunn <andrew@...n.ch>; Pandey, Radhey Shyam
> <radhey.shyam.pandey@....com>; netdev@...r.kernel.org
> Cc: Simek, Michal <michal.simek@....com>; linux-kernel@...r.kernel.org;
> Russell King <linux@...linux.org.uk>; David S . Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Eric Dumazet <edumazet@...gle.com>; Simon
> Horman <horms@...nel.org>; linux-arm-kernel@...ts.infradead.org; Sean
> Anderson <sean.anderson@...ux.dev>
> Subject: [PATCH net-next v4 1/2] net: xilinx: axienet: Report RxRject as
> rx_dropped
> 
> The Receive Frame Rejected interrupt is asserted whenever there was a
> receive error (bad FCS, bad length, etc.) or whenever the frame was
> dropped due to a mismatched address. So this is really a combination of
> rx_otherhost_dropped, rx_length_errors, rx_frame_errors, and
> rx_crc_errors. Mismatched addresses are common and aren't really errors
> at all (much like how fragments are normal on half-duplex links). To
> avoid confusion, report these events as rx_dropped. This better
> reflects what's going on: the packet was received by the MAC but dropped
> before being processed.
> 
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>

> ---
> 
> (no changes since v1)
> 
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index ca04c298daa2..b2d7c396e2e3 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1296,7 +1296,7 @@ static irqreturn_t axienet_eth_irq(int irq, void
> *_ndev)
>  		ndev->stats.rx_missed_errors++;
> 
>  	if (pending & XAE_INT_RXRJECT_MASK)
> -		ndev->stats.rx_frame_errors++;
> +		ndev->stats.rx_dropped++;
> 
>  	axienet_iow(lp, XAE_IS_OFFSET, pending);
>  	return IRQ_HANDLED;
> --
> 2.35.1.1320.gc452695387.dirty