linux-kernel - Re: [PATCH] Revert "scripts/faddr2line: Check only two symbols when calculating symbol size"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsTlxzwRK2tCTk68@google.com>
Date: Tue, 20 Aug 2024 18:51:51 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Brian Johannesmeyer <bjohannesmeyer@...il.com>
Cc: Will Deacon <will@...nel.org>, Josh Poimboeuf <jpoimboe@...nel.org>,
	linux-kernel@...r.kernel.org, kernel-team@...roid.com,
	John Stultz <jstultz@...gle.com>
Subject: Re: [PATCH] Revert "scripts/faddr2line: Check only two symbols when
 calculating symbol size"

On Tue, Aug 20, 2024 at 09:38:46AM -0700, Brian Johannesmeyer wrote:
> 
> Acked-by: Brian Johannesmeyer <bjohannesmeyer@...il.com>
> 
> Good catch. Thanks for the fix.
> 
> Just curious: What compiler did you use to build the kernel, where you
> hit this error with 'update_irq_load_avg'? I was unable to reproduce
> it with LLVM 14. Thanks!
> 

You should be able to reproduce this issue as long as you hit a NOTYPE
symbol as the second entry. Using aarch64 and CFI_CLANG will make this
scenario more likely to happen. I believe I used the following:

  $ make LLVM=1 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
  $ ./scripts/config -e CFI_CLANG
  ...

Cheers,
Carlos Llamas