linux-kernel - Re: [PATCH] sched_ext: Allow dequeue_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsTp8WeKCmNavWXl@slm.duckdns.org>
Date: Tue, 20 Aug 2024 09:09:37 -1000
From: Tejun Heo <tj@...nel.org>
To: Yipeng Zou <zouyipeng@...wei.com>
Cc: void@...ifault.com, mingo@...hat.com, peterz@...radead.org,
	juri.lelli@...hat.com, vincent.guittot@...aro.org,
	linux-kernel@...r.kernel.org, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
	vschneid@...hat.com
Subject: Re: [PATCH] sched_ext: Allow dequeue_task_scx to fail

On Tue, Aug 20, 2024 at 10:45:31AM +0800, Yipeng Zou wrote:
> Since dequeue_task() allowed to fail, there is a compile error:
> 
> kernel/sched/ext.c:3630:19: error: initialization of ‘bool (*)(struct rq*, struct task_struct *, int)’ {aka ‘_Bool (*)(struct rq *, struct task_struct *, int)’} from incompatible pointer type ‘void (*)(struct rq*, struct task_struct *, int)’
>   3630 |  .dequeue_task  = dequeue_task_scx,
>        |                   ^~~~~~~~~~~~~~~~
> 
> Allow dequeue_task_scx to fail too.
> 
> Fixes: 863ccdbb918a ("sched: Allow sched_class::dequeue_task() to fail")
> Signed-off-by: Yipeng Zou <zouyipeng@...wei.com>

Applied to sched_ext/for-6.12.

Thanks.

-- 
tejun