linux-kernel - Re: [PATCH -next] rcu: Remove unused declaration rcu_segcblist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bf549e6-204a-478e-ad9d-3b1b438befe4@paulmck-laptop>
Date: Tue, 20 Aug 2024 12:20:18 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: frederic@...nel.org, neeraj.upadhyay@...nel.org, joel@...lfernandes.org,
	josh@...htriplett.org, boqun.feng@...il.com, urezki@...il.com,
	rostedt@...dmis.org, mathieu.desnoyers@...icios.com,
	jiangshanlai@...il.com, qiang.zhang1211@...il.com,
	rcu@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] rcu: Remove unused declaration
 rcu_segcblist_offload()

On Thu, Aug 15, 2024 at 04:50:53PM +0800, Yue Haibing wrote:
> Commit 17351eb59abd ("rcu/nocb: Simplify (de-)offloading state machine")
> removed the implementation but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

Good eyes!

Reviewed-by: Paul E. McKenney <paulmck@...nel.org>

> ---
>  kernel/rcu/rcu_segcblist.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/rcu/rcu_segcblist.h b/kernel/rcu/rcu_segcblist.h
> index 259904075636..fadc08ad4b7b 100644
> --- a/kernel/rcu/rcu_segcblist.h
> +++ b/kernel/rcu/rcu_segcblist.h
> @@ -120,7 +120,6 @@ void rcu_segcblist_inc_len(struct rcu_segcblist *rsclp);
>  void rcu_segcblist_add_len(struct rcu_segcblist *rsclp, long v);
>  void rcu_segcblist_init(struct rcu_segcblist *rsclp);
>  void rcu_segcblist_disable(struct rcu_segcblist *rsclp);
> -void rcu_segcblist_offload(struct rcu_segcblist *rsclp, bool offload);
>  bool rcu_segcblist_ready_cbs(struct rcu_segcblist *rsclp);
>  bool rcu_segcblist_pend_cbs(struct rcu_segcblist *rsclp);
>  struct rcu_head *rcu_segcblist_first_cb(struct rcu_segcblist *rsclp);
> -- 
> 2.34.1
>