linux-kernel - Re: [PATCH] tools/crypto:Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57e4ba05-549c-49fd-a8a1-ec2437556ba3@amd.com>
Date: Tue, 20 Aug 2024 14:53:52 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/crypto:Remove unused variable

On 8/20/2024 02:42, Zhu Jun wrote:
> the variable is never referenced in the code, just remove them.

nit on the sentence:

s,the variable,the ret variable,
s,them,it,

> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>

Thank you!

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

> ---
>   tools/crypto/ccp/dbc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/crypto/ccp/dbc.c b/tools/crypto/ccp/dbc.c
> index a807df0f0597..80248d3d3a5a 100644
> --- a/tools/crypto/ccp/dbc.c
> +++ b/tools/crypto/ccp/dbc.c
> @@ -57,7 +57,6 @@ int process_param(int fd, int msg_index, __u8 *signature, int *data)
>   		.msg_index = msg_index,
>   		.param = *data,
>   	};
> -	int ret;
>   
>   	assert(signature);
>   	assert(data);