linux-kernel - Re: [PATCH v2] virtio_pmem: Check device status before requesting flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46eacc01-7b23-4f83-af3c-8c5897e44c90@intel.com>
Date: Tue, 20 Aug 2024 13:01:06 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Philip Chen <philipchen@...omium.org>,
 Pankaj Gupta <pankaj.gupta.linux@...il.com>,
 Dan Williams <dan.j.williams@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>
Cc: virtualization@...ts.linux.dev, nvdimm@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] virtio_pmem: Check device status before requesting
 flush



On 8/20/24 10:22 AM, Philip Chen wrote:
> If a pmem device is in a bad status, the driver side could wait for
> host ack forever in virtio_pmem_flush(), causing the system to hang.
> 
> So add a status check in the beginning of virtio_pmem_flush() to return
> early if the device is not activated.
> 
> Signed-off-by: Philip Chen <philipchen@...omium.org>
> ---
> 
> v2:
> - Remove change id from the patch description
> - Add more details to the patch description
> 
>  drivers/nvdimm/nd_virtio.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
> index 35c8fbbba10e..97addba06539 100644
> --- a/drivers/nvdimm/nd_virtio.c
> +++ b/drivers/nvdimm/nd_virtio.c
> @@ -44,6 +44,15 @@ static int virtio_pmem_flush(struct nd_region *nd_region)
>  	unsigned long flags;
>  	int err, err1;
>  
> +	/*
> +	 * Don't bother to submit the request to the device if the device is
> +	 * not acticated.

s/acticated/activated/

> +	 */
> +	if (vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_NEEDS_RESET) {
> +		dev_info(&vdev->dev, "virtio pmem device needs a reset\n");
> +		return -EIO;
> +	}
> +
>  	might_sleep();
>  	req_data = kmalloc(sizeof(*req_data), GFP_KERNEL);
>  	if (!req_data)