linux-kernel - Re: [PATCH 1/3] scsi: ufs: ufs-qcom: add fixup_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f984d1b7-2257-4506-83e0-73d52a10a75b@acm.org>
Date: Tue, 20 Aug 2024 14:32:05 -0700
From: Bart Van Assche <bvanassche@....org>
To: Manish Pandey <quic_mapa@...cinc.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, quic_cang@...cinc.com,
 quic_nguyenb@...cinc.com, quic_nitirawa@...cinc.com,
 quic_bhaskarv@...cinc.com, quic_narepall@...cinc.com,
 quic_rampraka@...cinc.com
Subject: Re: [PATCH 1/3] scsi: ufs: ufs-qcom: add fixup_dev_quirks vops

On 8/20/24 5:37 AM, Manish Pandey wrote:
> +static struct ufs_dev_quirk ufs_qcom_dev_fixups[] = {
> +	/* add UFS device specific quirks */
> +	{}
> +};

Please change the comment into /* UFS device-specific quirks */ and move
it above the array definition. I think that's the style followed by
kernel code.

Thanks,

Bart.