linux-kernel - Re: [PATCH 1/1] scsi: ufs-mediatek: Add UFSHCD_QUIRK_BROKEN_LSDBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <223cc3ca-9214-4ba1-a3c8-2d672aef52f9@acm.org>
Date: Tue, 20 Aug 2024 14:50:58 -0700
From: Bart Van Assche <bvanassche@....org>
To: Manivannan Sadhasivam <manisadhasivam.linux@...il.com>,
 Mary Guillemard <mary@...y.zone>
Cc: linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
 Peter Wang <peter.wang@...iatek.com>, Stanley Jhu <chu.stanley@...il.com>,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH 1/1] scsi: ufs-mediatek: Add UFSHCD_QUIRK_BROKEN_LSDBS_CAP

On 8/19/24 11:09 PM, Manivannan Sadhasivam wrote:
> On Mon, Aug 19, 2024 at 08:17:10PM +0200, Mary Guillemard wrote:
>> On Mon, Aug 19, 2024 at 05:38:52PM +0530, Manivannan Sadhasivam wrote:
>>> On Mon, Aug 19, 2024 at 12:24:42AM +0200, Mary Guillemard wrote:
>>>> +	if (host->caps & UFS_MTK_CAP_DISABLE_MCQ)
>>>
>>> How can this be the deciding factor? You said above that the issue is with
>>> MT8183 SoC. So why not just use the quirk only for that platform?
>>
>> So my current assumption is that it also affect other Mediatek SoCs
>> that are also based on UFS 2.1 spec but I cannot check this.
>>
>> Instead, we know that if MCQ isn't supported, we must fallback to LSDB
>> as there is no other ways to drive the device.
>>
>> UFS_MTK_CAP_DISABLE_MCQ (mediatek,ufs-disable-mcq) being unused upstream,
>> I think that's an acceptable fix.
>>
> 
> If you use this quirk, then you need to use the corresponding DT property. But
> using the 'mediatek,ufs-disable-mcq' property for 2.1 controller doesn't make
> sense as MCQ is for controllers >= 4.0.
> 
>> Another way to handle this would be to add a new dt property and add it
>> to ufs_mtk_host_caps but I feel that my approach should be enough.
>>
> 
> No need to add a DT property. Just use the SoC specific compatible as I did for
> SM8550 SoC.

Mary, do you plan to implement Manivannan's feedback?

Thanks,

Bart.