linux-kernel - Re: [PATCH 1/1] Driver: clk-qoriq.c: replace of_node_put with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b1107439ffd3fe3cf4945a500a881c8.sboyd@kernel.org>
Date: Tue, 20 Aug 2024 15:03:24 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: David Hunter <david.hunter.linux@...il.com>, mturquette@...libre.com
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, javier.carrasco.cruz@...il.com, shuah@...nel.org, david.hunter.linux@...il.com
Subject: Re: [PATCH 1/1] Driver: clk-qoriq.c: replace of_node_put with _free improves cleanup

Quoting David Hunter (2024-08-19 18:35:49)
> Use the _free function to have automatic clean up instead of calling

How about:

	Use __free() to have automatic cleanup instead of calling
	of_node_put() manually.

> another function, of_node_put. This prevents leaking reference counts.

Are there any leaking reference counts? I'd just omit that sentence
unless there is one.

> 
> The following commit has information on _free(device_node):
> 
> 9448e55d032d99af8e23487f51a542d51b2f1a48
> 
> The code was able to compile without errors or warnings. 

The rest of this can go below the triple dash ---