linux-kernel - Re: [PATCH v1] clk:clk-imx8-acm:fix wrong pointer check in clk_imx_acm_attach_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d4c39e109bcf288d5900670e024a315.sboyd@kernel.org>
Date: Tue, 20 Aug 2024 15:07:22 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Yuesong Li <liyuesong@...o.com>, abelvesa@...nel.org, mturquette@...libre.com, s.hauer@...gutronix.de, shawnguo@...nel.org
Cc: peng.fan@....com, kernel@...gutronix.de, festevam@...il.com, shengjiu.wang@....com, linux-clk@...r.kernel.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, opensource.kernel@...o.com, Yuesong Li <liyuesong@...o.com>
Subject: Re: [PATCH v1] clk:clk-imx8-acm:fix wrong pointer check in clk_imx_acm_attach_pm_domains()

Quoting Yuesong Li (2024-08-19 19:59:02)
> device_link_add() returns NULL pointer not PTR_ERR() when it fails,so
> replace the IS_ERR() check with NULL pointer check.

Can you document that fact by adding a "Return:" line to the kernel-doc
for device_link_add() in another patch?