linux-kernel - Re: regression: 9eac534db001 ("firmware/sysfb: Set firmware-framebuffer parent device") broke nomodeset boot?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ebeabdd2be02d26329345220e7e25d0ad6e5a9a.camel@gmx.de>
Date: Tue, 20 Aug 2024 05:47:52 +0200
From: Mike Galbraith <efault@....de>
To: LKML <linux-kernel@...r.kernel.org>
Cc: Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: regression: 9eac534db001 ("firmware/sysfb: Set
 firmware-framebuffer parent device") broke nomodeset boot?

On Tue, 2024-08-20 at 03:31 +0200, Mike Galbraith wrote:
>
> I haven't yet tried reverting the series...

Hey, how 'bout that, applying a mallot is not only easier, it works :)

---
 drivers/firmware/sysfb.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/firmware/sysfb.c
+++ b/drivers/firmware/sysfb.c
@@ -95,6 +95,7 @@ static __init bool sysfb_pci_dev_is_enab

 static __init struct device *sysfb_parent_dev(const struct screen_info *si)
 {
+#ifdef MEH_WHAT_COULD_GO_WRONG
 	struct pci_dev *pdev;

 	pdev = screen_info_pci_dev(si);
@@ -107,7 +108,7 @@ static __init struct device *sysfb_paren
 		}
 		return &pdev->dev;
 	}
-
+#endif
 	return NULL;
 }