linux-kernel - Re: [PATCH v6 14/22] x86/resctrl: Introduce cntr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d254ceda-7c6a-3e45-5da3-1c95724fc947@amd.com>
Date: Tue, 20 Aug 2024 17:42:53 -0500
From: "Moger, Babu" <bmoger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>,
 Babu Moger <babu.moger@....com>, corbet@....net, fenghua.yu@...el.com,
 tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, paulmck@...nel.org, rdunlap@...radead.org,
 tj@...nel.org, peterz@...radead.org, yanjiewtw@...il.com,
 kim.phillips@....com, lukas.bulwahn@...il.com, seanjc@...gle.com,
 jmattson@...gle.com, leitao@...ian.org, jpoimboe@...nel.org,
 rick.p.edgecombe@...el.com, kirill.shutemov@...ux.intel.com,
 jithu.joseph@...el.com, kai.huang@...el.com, kan.liang@...ux.intel.com,
 daniel.sneddon@...ux.intel.com, pbonzini@...hat.com, sandipan.das@....com,
 ilpo.jarvinen@...ux.intel.com, peternewman@...gle.com,
 maciej.wieczor-retman@...el.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, eranian@...gle.com, james.morse@....com
Subject: Re: [PATCH v6 14/22] x86/resctrl: Introduce cntr_id in mongroup for
 assignments

Hi Reinette,

On 8/16/2024 4:38 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 8/6/24 3:00 PM, Babu Moger wrote:
>> mbm_cntr_assignable feature provides an option to the user to assign a
>> hardware counter to an RMID and monitor the bandwidth as long as the
>> counter is assigned. There can be two counters per monitor group, one
>> for total event and another for local event.
>>
>> Introduce cntr_id to manage the assignments.
>>
>> Signed-off-by: Babu Moger <babu.moger@....com>
>> ---
>> v6: New patch.
>>      Separated FS and arch bits.
>> ---
>>   arch/x86/kernel/cpu/resctrl/internal.h | 7 +++++++
>>   arch/x86/kernel/cpu/resctrl/rdtgroup.c | 6 ++++++
>>   2 files changed, 13 insertions(+)
>>
>> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h 
>> b/arch/x86/kernel/cpu/resctrl/internal.h
>> index af3efa35a62e..d93082b65d69 100644
>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>> @@ -41,6 +41,11 @@
>>   /* Setting bit 0 in L3_QOS_EXT_CFG enables the ABMC feature. */
>>   #define ABMC_ENABLE_BIT            0
>> +/* Maximum assignable counters per resctrl group */
>> +#define MAX_CNTRS            2
>> +
>> +#define MON_CNTR_UNSET            U32_MAX
>> +
>>   /**
>>    * cpumask_any_housekeeping() - Choose any CPU in @mask, preferring 
>> those that
>>    *                    aren't marked nohz_full
>> @@ -210,12 +215,14 @@ enum rdtgrp_mode {
>>    * @parent:            parent rdtgrp
>>    * @crdtgrp_list:        child rdtgroup node list
>>    * @rmid:            rmid for this rdtgroup
>> + * @cntr_id:            Counter ids for assignment
> 
> Could this be:
> "IDs of hardware counters assigned to monitor group"
> 

Sure. Will do.

-- 
- Babu Moger