linux-kernel - Re: [net-next v4 4/5] net: stmmac: Add PCI driver support for BCM8958x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMdnO-LT8gChytPpw0HWqkJvL-=OWqHOY9UUj1gEXawyC=2TWA@mail.gmail.com>
Date: Tue, 20 Aug 2024 16:16:22 -0700
From: Jitendra Vegiraju <jitendra.vegiraju@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, alexandre.torgue@...s.st.com, joabreu@...opsys.com, 
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	mcoquelin.stm32@...il.com, bcm-kernel-feedback-list@...adcom.com, 
	richardcochran@...il.com, ast@...nel.org, daniel@...earbox.net, 
	hawk@...nel.org, john.fastabend@...il.com, fancer.lancer@...il.com, 
	rmk+kernel@...linux.org.uk, ahalaney@...hat.com, xiaolei.wang@...driver.com, 
	rohan.g.thomas@...el.com, Jianheng.Zhang@...opsys.com, 
	leong.ching.swee@...el.com, linux-kernel@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, bpf@...r.kernel.org, andrew@...n.ch, 
	linux@...linux.org.uk, horms@...nel.org, florian.fainelli@...adcom.com
Subject: Re: [net-next v4 4/5] net: stmmac: Add PCI driver support for BCM8958x

On Fri, Aug 16, 2024 at 11:27 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 14 Aug 2024 15:18:17 -0700 jitendra.vegiraju@...adcom.com wrote:
> > +     pci_restore_state(pdev);
> > +     pci_set_power_state(pdev, PCI_D0);
> > +
> > +     ret = pci_enable_device(pdev);
> > +     if (ret)
> > +             return ret;
> > +
> > +     pci_set_master(pdev);
>
> pci_restore_state() doesn't restore master and enable?
Hi Jakub,
Thanks for the feedback. You are correct, The pci_enable_device() and
pci_set_master() calls are not necessary.
We did more testing without these calls.
We will remove the calls.
Thanks