[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240820162010.1e89b641@kernel.org>
Date: Tue, 20 Aug 2024 16:20:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Rik van Riel
<riel@...riel.com>
Subject: Re: [PATCH net-next v2 1/3] netpoll: Ensure clean state on setup
failures
On Mon, 19 Aug 2024 03:36:11 -0700 Breno Leitao wrote:
> + DEBUG_NET_WARN_ON_ONCE(np->dev);
> if (ndev->priv_flags & IFF_DISABLE_NETPOLL) {
> np_err(np, "%s doesn't support polling, aborting\n",
> - np->dev_name);
> + ndev->name);
> err = -ENOTSUPP;
> goto out;
> }
> put:
> + DEBUG_NET_WARN_ON_ONCE(np->dev);
nit: having two warnings feels a bit excessive, let's pick one location?
Powered by blists - more mailing lists