linux-kernel - Re: [PATCH v2] mm: skip less than check for MAX_NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240819214055.978b33eae88004d35b9ce634@linux-foundation.org>
Date: Mon, 19 Aug 2024 21:40:55 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: alexs@...nel.org
Cc: linux-kernel@...r.kernel.org (open list), linux-mm@...ck.org
Subject: Re: [PATCH v2] mm: skip less than check for MAX_NR_ZONES

On Mon, 19 Aug 2024 19:26:28 +0800 alexs@...nel.org wrote:

> From: Alex Shi <alexs@...nel.org>
> 
> Remove unnecessary '<' check for ZONES_SHIFT assignment.
> 
> ...
>
> --- a/include/linux/page-flags-layout.h
> +++ b/include/linux/page-flags-layout.h
> @@ -14,7 +14,7 @@
>   */
>  #if MAX_NR_ZONES < 2
>  #define ZONES_SHIFT 0
> -#elif MAX_NR_ZONES <= 2
> +#elif MAX_NR_ZONES == 2
>  #define ZONES_SHIFT 1
>  #elif MAX_NR_ZONES <= 4
>  #define ZONES_SHIFT 2

mmm, why.  I think it looks more logical (and certainly more
consistent) the way things are now.