linux-kernel - Re: [PATCH net-next v1 1/3] ethtool: Extend cable testing interface with result source information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240819172608.2ca87928@kernel.org>
Date: Mon, 19 Aug 2024 17:26:08 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v1 1/3] ethtool: Extend cable testing interface
 with result source information

On Mon, 19 Aug 2024 16:12:39 +0200 Oleksij Rempel wrote:
> --- a/include/uapi/linux/ethtool_netlink.h
> +++ b/include/uapi/linux/ethtool_netlink.h
> @@ -573,15 +573,25 @@ enum {
>  	ETHTOOL_A_CABLE_RESULT_UNSPEC,
>  	ETHTOOL_A_CABLE_RESULT_PAIR,		/* u8 ETHTOOL_A_CABLE_PAIR_ */
>  	ETHTOOL_A_CABLE_RESULT_CODE,		/* u8 ETHTOOL_A_CABLE_RESULT_CODE_ */
> +	ETHTOOL_A_CABLE_RESULT_SRC,		/* u32 */
>  
>  	__ETHTOOL_A_CABLE_RESULT_CNT,
>  	ETHTOOL_A_CABLE_RESULT_MAX = (__ETHTOOL_A_CABLE_RESULT_CNT - 1)
>  };
>  
> +/* Information source for specific results. */
> +enum {
> +	/* Results provided by the Time Domain Reflectometry (TDR) */
> +	ETHTOOL_A_CABLE_INF_SRC_TDR,
> +	/* Results provided by the Active Link Cable Diagnostic (ALCD) */
> +	ETHTOOL_A_CABLE_INF_SRC_ALCD,
> +};
> +
>  enum {
>  	ETHTOOL_A_CABLE_FAULT_LENGTH_UNSPEC,
>  	ETHTOOL_A_CABLE_FAULT_LENGTH_PAIR,	/* u8 ETHTOOL_A_CABLE_PAIR_ */
>  	ETHTOOL_A_CABLE_FAULT_LENGTH_CM,	/* u32 */
> +	ETHTOOL_A_CABLE_FAULT_LENGTH_SRC,	/* u32 */

Please keep Documentation/netlink/specs/ethtool.yaml up to date