linux-kernel - [PATCH] tools/perf:Remove unnecessary assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20240820070212.4572-1-zhujun2@cmss.chinamobile.com>
Date: Tue, 20 Aug 2024 00:02:12 -0700
From: Zhu Jun <zhujun2@...s.chinamobile.com>
To: suzuki.poulose@....com
Cc: mike.leach@...aro.org,
	james.clark@...aro.org,
	mark.rutland@....com,
	irogers@...gle.com,
	adrian.hunter@...el.com,
	kan.liang@...ux.intel.com,
	linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Zhu Jun <zhujun2@...s.chinamobile.com>
Subject: [PATCH] tools/perf:Remove unnecessary assignment

In the function cs_etm_decoder__init_def_logger_printing(),
the correct logic should be to return within the function
when ret is not equal to 0.

Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
---
 tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
index e917985bbbe6..dc80576180d5 100644
--- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
+++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
@@ -238,6 +238,7 @@ cs_etm_decoder__init_def_logger_printing(struct cs_etm_decoder_params *d_params,
 					      cs_etm_decoder__print_str_cb);
 	if (ret != 0)
 		ret = -1;
+		return -1;
 
 	return 0;
 }
-- 
2.17.1