linux-kernel - Re: [PATCH v3 04/14] thermal: sysfs: Use the dev argument in instance-related show/store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <132e3703d5f82379bd634712fe624764b43423aa.camel@intel.com>
Date: Tue, 20 Aug 2024 07:05:32 +0000
From: "Zhang, Rui" <rui.zhang@...el.com>
To: "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, "rjw@...ysocki.net"
	<rjw@...ysocki.net>
CC: "lukasz.luba@....com" <lukasz.luba@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>
Subject: Re: [PATCH v3 04/14] thermal: sysfs: Use the dev argument in
 instance-related show/store

On Mon, 2024-08-19 at 17:56 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Two sysfs show/store functions for attributes representing thermal
> instances, trip_point_show() and weight_store(), retrieve the thermal
> zone pointer from the instance object at hand, but they may also get
> it from their dev argument, which is more consistent with what the
> other thermal sysfs functions do, so make them do so.
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reviewed-by: Zhang Rui <rui.zhang@...el.com>

thanks,
rui

> ---
> 
> v1 -> v3: No changes (previously [06/17])
> 
> ---
>  drivers/thermal/thermal_sysfs.c |   15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> Index: linux-pm/drivers/thermal/thermal_sysfs.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/thermal_sysfs.c
> +++ linux-pm/drivers/thermal/thermal_sysfs.c
> @@ -836,13 +836,12 @@ void thermal_cooling_device_stats_reinit
>  ssize_t
>  trip_point_show(struct device *dev, struct device_attribute *attr,
> char *buf)
>  {
> +       struct thermal_zone_device *tz = to_thermal_zone(dev);
>         struct thermal_instance *instance;
>  
> -       instance =
> -           container_of(attr, struct thermal_instance, attr);
> +       instance = container_of(attr, struct thermal_instance, attr);
>  
> -       return sprintf(buf, "%d\n",
> -                      thermal_zone_trip_id(instance->tz, instance-
> >trip));
> +       return sprintf(buf, "%d\n", thermal_zone_trip_id(tz,
> instance->trip));
>  }
>  
>  ssize_t
> @@ -858,6 +857,7 @@ weight_show(struct device *dev, struct d
>  ssize_t weight_store(struct device *dev, struct device_attribute
> *attr,
>                      const char *buf, size_t count)
>  {
> +       struct thermal_zone_device *tz = to_thermal_zone(dev);
>         struct thermal_instance *instance;
>         int ret, weight;
>  
> @@ -868,14 +868,13 @@ ssize_t weight_store(struct device *dev,
>         instance = container_of(attr, struct thermal_instance,
> weight_attr);
>  
>         /* Don't race with governors using the 'weight' value */
> -       mutex_lock(&instance->tz->lock);
> +       mutex_lock(&tz->lock);
>  
>         instance->weight = weight;
>  
> -       thermal_governor_update_tz(instance->tz,
> -                                  THERMAL_INSTANCE_WEIGHT_CHANGED);
> +       thermal_governor_update_tz(tz,
> THERMAL_INSTANCE_WEIGHT_CHANGED);
>  
> -       mutex_unlock(&instance->tz->lock);
> +       mutex_unlock(&tz->lock);
>  
>         return count;
>  }
> 
> 
>