linux-kernel - [PATCH] ncsi: Support sparse package ids in ncsi_write_package

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20240820070541.156601-1-jlamanna@gmail.com>
Date: Tue, 20 Aug 2024 07:05:41 +0000
From: James Lamanna <jlamanna@...il.com>
To: sam@...dozajonas.com
Cc: linux-kernel@...r.kernel.org,
	James Lamanna <jlamanna@...il.com>
Subject: [PATCH] ncsi: Support sparse package ids in ncsi_write_package_info

For platforms with sparse package ids, where package_num < max(package_id)-1,
a check against package_num would prevent the return of package info.

This removes that check as it breaks these platforms and is an incorrect
comparison (package_id vs number of packages).

Invalid package_ids are checked in the following loop, and
-ENODEV is still returned if there are no matches.

Signed-off-by: James Lamanna <jlamanna@...il.com>
---
 net/ncsi/ncsi-netlink.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/net/ncsi/ncsi-netlink.c b/net/ncsi/ncsi-netlink.c
index 2f872d064396..62fabcc000c9 100644
--- a/net/ncsi/ncsi-netlink.c
+++ b/net/ncsi/ncsi-netlink.c
@@ -100,11 +100,6 @@ static int ncsi_write_package_info(struct sk_buff *skb,
 	bool found;
 	int rc;
 
-	if (id > ndp->package_num - 1) {
-		netdev_info(ndp->ndev.dev, "NCSI: No package with id %u\n", id);
-		return -ENODEV;
-	}
-
 	found = false;
 	NCSI_FOR_EACH_PACKAGE(ndp, np) {
 		if (np->id != id)
-- 
2.34.1