linux-kernel - Re: [PATCH v10 3/4] firmware: ti_sci: Introduce Power Management Ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cde0930-5296-4707-a4b3-3ef060206625@ti.com>
Date: Tue, 20 Aug 2024 13:50:49 +0530
From: Akashdeep Kaur <a-kaur@...com>
To: Kevin Hilman <khilman@...libre.com>, Nishanth Menon <nm@...com>,
        Tero
 Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Vibhore Vardhan <vibhore@...com>, Dhruva Gole <d-gole@...com>,
        Markus
 Schneider-Pargmann <msp@...libre.com>
Subject: Re: [PATCH v10 3/4] firmware: ti_sci: Introduce Power Management Ops

On 14/08/24 21:09, Kevin Hilman wrote:
> From: Dave Gerlach <d-gerlach@ ti. com> Introduce power management ops 
> supported by the TISCI Low Power Mode API [1]. 1) 
> TISCI_MSG_LPM_WAKE_REASON Get which wake up source woke the SoC from Low 
> Power Mode. The wake up source IDs will be
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source 
> of this email and know the content is safe.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!tFdqXRfP9mwbCoXPtNggdrCuJ3bSsNDHabWG8s9g6Hh_v3tSab2OpTcpCeIxxvksAU_Fa5Zl41XmoQoqJiZdQtEck4kHNZot31hxXq-ZtaRCwdotcPeN9ST2tD8$>
> ZjQcmQRYFpfptBannerEnd
> 
> From: Dave Gerlach <d-gerlach@...com>
> 
> Introduce power management ops supported by the TISCI
> Low Power Mode API [1].
> 
> 1) TISCI_MSG_LPM_WAKE_REASON
> Get which wake up source woke the SoC from Low Power Mode.
> The wake up source IDs will be common for all K3 platforms.
> 
> 2) TISCI_MSG_LPM_SET_DEVICE_CONSTRAINT
> Set LPM constraint on behalf of a device. By setting a constraint, the
> device ensures that it will not be powered off or reset in the selected
> mode.
> 
> 3) TISCI_MSG_LPM_SET_LATENCY_CONSTRAINT
> Set LPM resume latency constraint. By setting a constraint, the host
> ensures that the resume time from selected mode will be less than the
> constraint value.
> 
> [1] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html
> 
> Signed-off-by: Dave Gerlach <d-gerlach@...com>
> [g-vlaev@...com: LPM_WAKE_REASON and IO_ISOLATION support]
> Signed-off-by: Georgi Vlaev <g-vlaev@...com>
> [a-kaur@...com: SET_DEVICE_CONSTRAINT support]
> Signed-off-by: Akashdeep Kaur <a-kaur@...com>
> [vibhore@...com: SET_LATENCY_CONSTRAINT support]
> Signed-off-by: Vibhore Vardhan <vibhore@...com>
> Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> Signed-off-by: Kevin Hilman <khilman@...libre.com>
> ---
[...]

My concerns are now addressed.

Reviewed-by: Akashdeep Kaur <a-kaur@...com>