linux-kernel - Re: [PATCH 1/2] x86/kexec: Fix a comment of swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <q2y5vte3wwn5qde5p4nfmjfqtzxfen3nhjdyafc7nbirfidpvr@ro3djjz3pub4>
Date: Tue, 20 Aug 2024 11:40:44 +0300
From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To: Kai Huang <kai.huang@...el.com>
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, 
	dave.hansen@...el.com, hpa@...or.com, peterz@...radead.org, x86@...nel.org, 
	linux-kernel@...r.kernel.org, nik.borisov@...e.com
Subject: Re: [PATCH 1/2] x86/kexec: Fix a comment of swap_pages() assembly

On Tue, Aug 20, 2024 at 12:21:11AM +1200, Kai Huang wrote:
> When relocate_kernel() gets called, %rdi holds 'indirection_page' and
> %rsi holds 'page_list'.  And %rdi always holds 'indirection_page' when
> swap_pages() is called.
> 
> Therefore the comment of the first line code of swap_pages()
> 
> 	movq    %rdi, %rcx      /* Put the page_list in %rcx */
> 
> .. isn't correct because it actually moves the 'indirection_page' to
> the %rcx.  Fix it.
> 
> Signed-off-by: Kai Huang <kai.huang@...el.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

Looks like it got broken by 4bfaaef01a1b ("[PATCH] Avoid overwriting the
current pgd (V4, x86_64)")

-- 
  Kiryl Shutsemau / Kirill A. Shutemov