linux-kernel - Re: [PATCH -next 2/8] pmdomain: Make apple_pmgr_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqLejTCtQfU=MX587D7S3O15dZm6S3Ecz4qJTf3GOOGfw@mail.gmail.com>
Date: Tue, 20 Aug 2024 11:33:55 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: marcan@...can.st, sven@...npeter.dev, alyssa@...enzweig.io, 
	p.zabel@...gutronix.de, linux-arm-kernel@...ts.infradead.org, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 2/8] pmdomain: Make apple_pmgr_reset_ops static

On Mon, 19 Aug 2024 at 13:52, Jinjie Ruan <ruanjinjie@...wei.com> wrote:
>
> The sparse tool complains as follows:
>
> drivers/pmdomain/apple/pmgr-pwrstate.c:180:32: warning:
>         symbol 'apple_pmgr_reset_ops' was not declared. Should it be static:
>
> This symbol is not used outside of pmgr-pwrstate.c, so marks it static.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/pmdomain/apple/pmgr-pwrstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/apple/pmgr-pwrstate.c b/drivers/pmdomain/apple/pmgr-pwrstate.c
> index d62a776c89a1..9467235110f4 100644
> --- a/drivers/pmdomain/apple/pmgr-pwrstate.c
> +++ b/drivers/pmdomain/apple/pmgr-pwrstate.c
> @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned
>         return !!(reg & APPLE_PMGR_RESET);
>  }
>
> -const struct reset_control_ops apple_pmgr_reset_ops = {
> +static const struct reset_control_ops apple_pmgr_reset_ops = {
>         .assert         = apple_pmgr_reset_assert,
>         .deassert       = apple_pmgr_reset_deassert,
>         .reset          = apple_pmgr_reset_reset,
> --
> 2.34.1
>