linux-kernel - Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <266f4b55-bddb-4c44-9eb5-3eef35757714@kernel.org>
Date: Tue, 20 Aug 2024 12:01:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ryan Chen <ryan_chen@...eedtech.com>,
 "brendan.higgins@...ux.dev" <brendan.higgins@...ux.dev>,
 "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
 "joel@....id.au" <joel@....id.au>,
 "andi.shyti@...nel.org" <andi.shyti@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
 "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
 "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for
 AST2600-i2cv2

On 20/08/2024 08:50, Ryan Chen wrote:
>>>> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for
>>>> AST2600-i2cv2
>>>>
>>>> On 19/08/2024 11:28, Ryan Chen wrote:
>>>>> Add ast2600-i2cv2 compatible and aspeed,global-regs,
>>>>> aspeed,enable-dma and description for ast2600-i2cv2.
>>>>>
>>>>> Signed-off-by: Ryan Chen <ryan_chen@...eedtech.com>
>>>>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@...nel.org>
>>>>
>>>> ?!?
>>>>
>>>> What happened here? Why are you amending tags?!? That's not allowed.
>>>> You cannot change received tags, change people names or their data!
>>>> And how is it even possible, srsly, how do you even work with git?
>>>> Git would never do it, so you had to do it on purpose via some weird
>> workflow.
>>>>
>>> Sorry, I don't know Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> is
>> you or not.
>>> Or should I still keep Krzysztof Kozlowski <krzk+dt@...nel.org>?
>>>
>>> https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777
>>> 768-2-ryan_chen@...eedtech.com/
>>
>> Here is the tag you received. You added it in v12.
>>
>> Why did you change the tag suddenly to something else?
>>
>> Do you understand that you are not allowed to change people tags? I have
>> doubts if you ask about people's identities, which is entirely irrelevant.
>>
> Sorry, I am not understood.

I don't know how to say this simpler that you are not allowed to change
tags.

You receive tag, use b4 to apply it or add it manually. Do not alter it.
Do not change it. Do not add things there. Do not remove parts of it.

Tag is as is. You only copy and paste.

Is this understood now?



> https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777768-2-ryan_chen@aspeedtech.com/
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> at v10
> So, what should I do now at v13?? 

Fix your workflow and go back to previous version which had correct tag.
And answer - why did you decide to change it?

Best regards,
Krzysztof